Skip to content

test: terminate WPT workers after test completion #37627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: terminate WPT workers after test completion #37627

wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

@targos targos commented Mar 6, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2021
aduh95
aduh95 reviewed Mar 6, 2021
View reviewed changes
test/common/wpt.js
this.inProgress.delete(filename);
// Always force termination of the worker. Some tests allocate resources
// that would otherwise keep it alive.
this.workers.get(filename).terminate();
Copy link
Contributor

@aduh95 aduh95 Mar 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's safe to ignore the Promise status, maybe add an empty catch handler?

Suggested change
this.workers.get(filename).terminate();
this.workers.get(filename).terminate().catch(() => {});

Copy link
Member Author

@targos targos Mar 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This promise can never reject

node/lib/internal/worker.js

Lines 344 to 354 in f3d3769

if (this[kHandle] === null) return PromiseResolve();
this[kHandle].stopThread();
// Do not use events.once() here, because the 'exit' event will always be
// emitted regardless of any errors, and the point is to only resolve
// once the thread has actually stopped.
return new Promise((resolve) => {
this.once('exit', resolve);
});
}

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 6, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36510/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 8, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36541/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 8, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36545/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 8, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36546/

targos added a commit that referenced this pull request Mar 8, 2021
@targos
test: terminate WPT workers after test completion
bba5aac 
PR-URL: #37627
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos
Copy link
Member Author

targos commented Mar 8, 2021

Landed in bba5aac

@targos targos closed this Mar 8, 2021
@targos targos deleted the wpt-worker branch March 8, 2021 20:57
@targos targos mentioned this pull request Mar 9, 2021
Closed
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@targos @danielleadams
test: terminate WPT workers after test completion
f7edb07 
PR-URL: #37627
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@targos @nodejs-github-bot @Trott @aduh95