src: add error formatting support #37598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
devsnek
force-pushed
the
better-native-errors
branch
from
79a1cce
to
db938cf
Compare
RaisinTen
reviewed
Mar 4, 2021
devsnek
force-pushed
the
better-native-errors
branch
from
db938cf
to
caaffe6
Compare
devsnek
force-pushed
the
better-native-errors
branch
from
caaffe6
to
21b4ee7
Compare
jasnell
approved these changes
Mar 5, 2021
aduh95
added
the
author ready
RaisinTen
approved these changes
Mar 6, 2021
|
Does this need a documentation update (for the error code) ? |
devsnek
force-pushed
the
better-native-errors
branch
from
21b4ee7
to
4434596
Compare
targos
approved these changes
Mar 9, 2021
|
Is "rebuild" or "retry" the correct button for just doing the failed runners |
|
The correct button is "Resume build" |
|
Close enough 😄 |
PR-URL: nodejs#37598 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek
force-pushed
the
better-native-errors
branch
from
4434596
to
853086f
Compare
|
landed in 853086f |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37598 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37598 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the use of format strings in our native error functions. It also includes some light usage in ModuleWrap.