build: fix GYP settings to avoid rebuilding already built files#37429
Closed
aduh95 wants to merge 3 commits intonodejs:masterfrom
Closed
build: fix GYP settings to avoid rebuilding already built files#37429aduh95 wants to merge 3 commits intonodejs:masterfrom
aduh95 wants to merge 3 commits intonodejs:masterfrom
Conversation
targos
reviewed
Feb 18, 2021
Contributor
Author
|
Hum so the build is failing on GH Actions, while the build works on my machine 🥲 |
Member
Are you cleaning all build artifacts when you build locally? Actions runs on a clean clone/checkout. |
Member
|
At this point I think we need someone who knows makefiles to look at the one generated for |
targos
added a commit
to targos/node
that referenced
this pull request
Feb 24, 2021
Until we have a fix for the makefiles generated by GYP. Refs: nodejs#37429
Contributor
Author
|
This is fixed by #37505. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my naive attempt at reducing the time it takes to GitHub Actions to run the test suite. My understanding is that a change in #36139 broke ability for the build chain to know which build artefacts are up to date. It attempts to rebuild everything, which may go unnoticed when ccache is setup, but we don't have it setup on GH Actions.
//cc @nodejs/v8