Merged
Conversation
PR-URL: #37173 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
nodejs-github-bot
added
build
ruyadorno
force-pushed
the
v12.20.2-proposal
branch
from
34eefac to
6310a81
Compare
Member
Author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
richardlau
approved these changes
Feb 9, 2021
BethGriggs
approved these changes
Feb 9, 2021
Member
|
Looks like the V8 CI is failing |
Member
Author
|
maybe I'm missing some test updates? cc @targos @BethGriggs are the V8 tests also failing in your current v14.x-proposal? |
Member
|
@ruyadorno - V8 tests passed for v14.x (rebuild to confirm). 🤔 |
If exit is called and then run or enterWith are called within the exit function, the als instace should not be added to the storageList additional times. The correct behaviour is to remove the instance from the storageList before executing the exit handler and then to restore it after. PR-URL: #35779 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
Author
|
I'll drop 680496ee10 and proceed with the release without it 😊 |
ruyadorno
force-pushed
the
v12.20.2-proposal
branch
from
6310a81 to
abf8088
Compare
Collaborator
richardlau
approved these changes
Feb 10, 2021
ruyadorno
added a commit
to ruyadorno/nodejs.org
that referenced
this pull request
Feb 10, 2021
ruyadorno
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 10, 2021
4 tasks
targos
removed
build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2021-02-10, Version 12.20.2 'Erbium' (LTS), @ruyadorno
Notable changes
Commits
e8a4e560ea] - async_hooks: fix leak in AsyncLocalStorage exit (Stephen Belanger) #35779427968d266] - deps: upgrade npm to 6.14.11 (Ruy Adorno) #37173cd9a8106be] - http: do not loop over prototype in Agent (Michaël Zasso) #364104ac8f37800] - http2: check write not scheduled in scope destructor (David Halls) #36241