Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move code of conduct to it's own file #3722

Closed
wants to merge 1 commit into from
Closed

meta: move code of conduct to it's own file #3722

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

Currently the code of conduct exists but it is somewhat hidden in
CONTRIBUTING.md

This PR creates CODE_OF_CONDUCT.md that contains the copy originally
found in CONTRIBUTING.md

Currently the code of conduct exists but it is somewhat hidden in
CONTRIBUTING.md

This PR creates CODE_OF_CONDUCT.md that contains the copy originally
found in CONTRIBUTING.md
@MylesBorins
Copy link
Contributor Author

@mikeal
Copy link
Contributor

mikeal commented Nov 9, 2015

habitual comment about adding more ALLCAPS top-level files

Just getting that out of the way :)

But in seriousness, it should be in CONTRIBUTING.md because only CONTRIBUTING.md is linked to when submitting a pull request.

@MylesBorins
Copy link
Contributor Author

That's reasonable... maybe we should add something to the README.md instead? My main concern is that the Code of conduct is not very discoverable

@mikeal
Copy link
Contributor

mikeal commented Nov 9, 2015

A link in the README seems appropriate. While we're at it we should link to all the other files there like the COLLABORATOR_GUIDE.

@MylesBorins
Copy link
Contributor Author

It seems like there are already a handful of links here

--> https://github.com/nodejs/node#resources-for-newcomers

I'm going to take a pass at that copy

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Nov 9, 2015
@bnoordhuis
Copy link
Member

But in seriousness, it should be in CONTRIBUTING.md because only CONTRIBUTING.md is linked to when submitting a pull request.

One criticism I've heard is that no one reads it because it's too big.

@silverwind
Copy link
Contributor

How about putting it on either the Wiki or in doc? Not too fond of adding another root level file.

@MylesBorins
Copy link
Contributor Author

closing in lieu of #3774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants