stream: refactor to avoid unsafe array iteration#37126
Merged
aduh95 merged 1 commit intonodejs:masterfrom Feb 1, 2021
Merged
Conversation
Contributor
Author
|
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/913/ EDIT: No significant regressions, and one perf improvement: Details |
Lxxyx
approved these changes
Jan 30, 2021
Collaborator
Contributor
Author
3 tasks
RaisinTen
approved these changes
Feb 1, 2021
PR-URL: nodejs#37126 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
1666ca7 to
4ad46e2
Compare
Contributor
Author
|
Landed in 4ad46e2 |
Member
|
I'm a bit concerned that so many changes to streams lands without a @nodejs/streams approval. @nodejs/tsc wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes changes from #36346 (which has not landed yet pending reviews), please review only 1666ca7 on this thread.