readline: check for null input in question()#37089
Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
Closed
readline: check for null input in question()#37089cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig wants to merge 1 commit intonodejs:masterfrom
Conversation
question() checks for objects passed as the recently added options argument. This commit improves that logic to also check for null.
nodejs-github-bot
added
the
readline
Lxxyx
approved these changes
Jan 27, 2021
Collaborator
jasnell
approved these changes
Jan 27, 2021
cjihrig
added
the
author ready
juanarbol
approved these changes
Jan 27, 2021
RaisinTen
approved these changes
Jan 28, 2021
Lxxyx
pushed a commit
that referenced
this pull request
Jan 29, 2021
question() checks for objects passed as the recently added options argument. This commit improves that logic to also check for null. PR-URL: #37089 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Member
|
Landed in b02030d |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
question() checks for objects passed as the recently added options argument. This commit improves that logic to also check for null. PR-URL: #37089 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
question()checks for objects passed as the recently addedoptionsargument. This commit improves that logic to also check for null.