Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use top-level await syntax in vm.md #37077

Closed
wants to merge 1 commit into from
Closed

doc: use top-level await syntax in vm.md #37077

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 26, 2021

TLA allows us to use more concise example and get rid of IIFE async functions.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 26, 2021
@aduh95 aduh95 added the doc Issues and PRs related to the documentations. label Jan 26, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35773/

RaisinTen
RaisinTen reviewed Jan 27, 2021
View reviewed changes
doc/api/vm.md Outdated Show resolved Hide resolved
RaisinTen
RaisinTen reviewed Jan 27, 2021
View reviewed changes
doc/api/vm.md Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Jan 27, 2021
View reviewed changes
doc/api/vm.md Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Jan 31, 2021

This would change the examples to be ones that cannot be placed in a .js file (let's say index.js) and run as node index.js. To me, that's a pretty big change and one we'd want to sort out across the docs. But maybe I'm wrong. @nodejs/documentation

@aduh95 aduh95 mentioned this pull request Jan 31, 2021
Merged
4 tasks
@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 1, 2021

Removed author ready label to try to get more opinions before landing. I've also opened #37162 to address the more general issue.

@aduh95 aduh95 added review wanted PRs that need reviews. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 4, 2021
jasnell pushed a commit that referenced this pull request Mar 5, 2021
@aduh95 @jasnell
doc: add top-level await syntax in vm.md
2be512d 
PR-URL: #37077
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 5, 2021

Landed in 2be512d

@jasnell jasnell closed this Mar 5, 2021
@aduh95 aduh95 deleted the vm-doc-tla branch March 5, 2021 18:14
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
doc: add top-level await syntax in vm.md
e0e7aa1 
PR-URL: #37077
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
doc: add top-level await syntax in vm.md
183dba0 
PR-URL: #37077
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExE-Boss ExE-Boss ExE-Boss left review comments

@RaisinTen RaisinTen RaisinTen approved these changes

@aymen94 aymen94 aymen94 approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. review wanted PRs that need reviews. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aduh95 @nodejs-github-bot @Trott @jasnell @lpinca @ExE-Boss @aymen94 @RaisinTen