src: rename crypto_ecdh.(h|cc) to crypto_ec.(h|cc)#37048
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
src: rename crypto_ecdh.(h|cc) to crypto_ec.(h|cc)#37048tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen wants to merge 1 commit intonodejs:masterfrom
Conversation
tniessen
added
crypto
nodejs-github-bot
added
the
lib / src
cjihrig
approved these changes
Jan 24, 2021
jasnell
approved these changes
Jan 24, 2021
addaleax
approved these changes
Jan 24, 2021
jasnell
added
the
author ready
Collaborator
lpinca
approved these changes
Jan 24, 2021
Member
|
There's no reason for this to wait the full minimum time to land. Please 👍🏻 to fast-track |
Member
|
Landed in 7394311 |
jasnell
pushed a commit
that referenced
this pull request
Jan 25, 2021
PR-URL: #37048 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen
removed
the
author ready
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
PR-URL: #37048 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Oct 5, 2021
Trott
pushed a commit
to tniessen/node
that referenced
this pull request
Oct 7, 2021
Refs: nodejs#37048 PR-URL: nodejs#40332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto_ecdh.handcrypto_ecdh.ccdefine and implement things that are not only relevant to ECDH, but also to other ECC mechanisms, including ECDSA. The files should, therefore, just be calledcrypto_ec.*.