fs: refactor to remove redundant validation#36984
Closed
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Closed
fs: refactor to remove redundant validation#36984RaisinTen wants to merge 1 commit intonodejs:masterfrom
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Conversation
The function makeCallback already calls validateCallback, so the call inside copyFile can be removed.
nodejs-github-bot
added
the
fs
Member
Author
|
cc @nodejs/fs |
targos
approved these changes
Jan 18, 2021
aduh95
approved these changes
Jan 18, 2021
Collaborator
aduh95
added
the
author ready
cjihrig
approved these changes
Jan 18, 2021
lpinca
approved these changes
Jan 19, 2021
juanarbol
approved these changes
Jan 23, 2021
jasnell
approved these changes
Jan 23, 2021
Member
|
Landed in ae5e95f |
jasnell
pushed a commit
that referenced
this pull request
Jan 23, 2021
The function makeCallback already calls validateCallback, so the call inside copyFile can be removed. PR-URL: #36984 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
The function makeCallback already calls validateCallback, so the call inside copyFile can be removed. PR-URL: #36984 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
makeCallbackalready callsvalidateCallback, so the callinside
copyFilecan be removed.makeCallbackis called here:node/lib/fs.js
Line 2050 in 568b26a
and
makeCallbackcallsvalidateCallbackhere:node/lib/fs.js
Line 182 in 568b26a