Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused ecdhPeerKey #36942

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jan 15, 2021

This commit removed ecdhPeerKey from test-webcrypto-wrap-unwrap.js which
seems to be unsued.

This commit removed ecdhPeerKey from test-webcrypto-wrap-unwrap.js which
seems to be unsued.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 15, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
@jasnell
Copy link
Member

jasnell commented Jan 18, 2021

Landed in c880965

@jasnell jasnell closed this Jan 18, 2021
jasnell pushed a commit that referenced this pull request Jan 18, 2021
This commit removed ecdhPeerKey from test-webcrypto-wrap-unwrap.js which
seems to be unsued.

PR-URL: #36942
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
This commit removed ecdhPeerKey from test-webcrypto-wrap-unwrap.js which
seems to be unsued.

PR-URL: #36942
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
This commit removed ecdhPeerKey from test-webcrypto-wrap-unwrap.js which
seems to be unsued.

PR-URL: #36942
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants