test: use faster variant for rss in test-vm-memleak.js#36769
Closed
PoojaDurgad wants to merge 1 commit intonodejs:masterfrom
Closed
test: use faster variant for rss in test-vm-memleak.js#36769PoojaDurgad wants to merge 1 commit intonodejs:masterfrom
PoojaDurgad wants to merge 1 commit intonodejs:masterfrom
Conversation
Flarna
approved these changes
Jan 4, 2021
Lxxyx
approved these changes
Jan 4, 2021
Trott
requested changes
Jan 5, 2021
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Change looks good to me but it's not desirable (in my opinion, at least) to have multiple identical commit messages. Can we please update the commit message for this and the other PRs with identical names/commit messages so that they indicate the name of the test that is being changed?
PoojaDurgad
force-pushed
the
rss-memleak
branch
from
e110cb1 to
4180330
Compare
PoojaDurgad
changed the title
Contributor
Author
|
@Trott - fixed |
Trott
approved these changes
Jan 5, 2021
github-actions
bot
removed
the
request-ci
Collaborator
github-actions
bot
removed
the
request-ci
Collaborator
juanarbol
approved these changes
Jan 5, 2021
PoojaDurgad
added
the
author ready
Collaborator
jasnell
approved these changes
Jan 11, 2021
Member
|
Landed in 2ceb441 |
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#36769 Refs: nodejs#34291 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #34291
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes