fs: accept non-32-bit length in writeBuffer #36667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `length` is `size_t`, it can accept 64-bit integers too. Refs: https://man7.org/linux/man-pages/man2/write.2.html Fixes: nodejs#36643
nodejs-github-bot
added
c++
addaleax
approved these changes
Dec 28, 2020
aduh95
approved these changes
Dec 29, 2020
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
|
Would it be reasonable to add a test? |
Trott
approved these changes
Dec 29, 2020
I think it's not because it requires to write a file > 2GB to the disk. |
lpinca
approved these changes
Dec 29, 2020
yashLadha
approved these changes
Dec 30, 2020
yashLadha
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/36667 ✔ Done loading data for nodejs/node/pull/36667 ----------------------------------- PR info ------------------------------------ Title fs: accept non-32-bit length in writeBuffer (#36667) Author Darshan Sen (@RaisinTen) Branch RaisinTen:fs/fix-writeBuffer-length-assertion -> nodejs:master Labels author ready, c++, fs Commits 1 - fs: accept non-32-bit length in writeBuffer Committers 1 - raisinten PR-URL: https://github.com/nodejs/node/pull/36667 Fixes: https://github.com/nodejs/node/issues/36643 Refs: https://man7.org/linux/man-pages/man2/write.2.html Reviewed-By: Anna Henningsen Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Yash Ladha ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36667 Fixes: https://github.com/nodejs/node/issues/36643 Refs: https://man7.org/linux/man-pages/man2/write.2.html Reviewed-By: Anna Henningsen Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Yash Ladha -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-12-29T01:20:36Z: https://ci.nodejs.org/job/node-test-pull-request/35131/ - Querying data for job/node-test-pull-request/35131/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 28 Dec 2020 16:34:47 GMT ✔ Approvals: 5 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36667#pullrequestreview-559240760 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36667#pullrequestreview-559345231 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36667#pullrequestreview-559360796 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36667#pullrequestreview-559670637 ✔ - Yash Ladha (@yashLadha): https://github.com/nodejs/node/pull/36667#pullrequestreview-559756174 ✖ This PR needs to wait 14 more hours to land -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/451875945 |
himself65
approved these changes
Dec 30, 2020
RaisinTen
added
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 1b7ac0c...c380ee6 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 30, 2020
Since `length` is `size_t`, it can accept 64-bit integers too. Refs: https://man7.org/linux/man-pages/man2/write.2.html Fixes: #36643 PR-URL: #36667 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: Zeyu Yang <himself65@outlook.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Since `length` is `size_t`, it can accept 64-bit integers too. Refs: https://man7.org/linux/man-pages/man2/write.2.html Fixes: #36643 PR-URL: #36667 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Since `length` is `size_t`, it can accept 64-bit integers too. Refs: https://man7.org/linux/man-pages/man2/write.2.html Fixes: #36643 PR-URL: #36667 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
lengthissize_t, it can accept 64-bit integers too.Refs: https://man7.org/linux/man-pages/man2/write.2.html
Fixes: #36643
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes