Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add coverage for breakLength one-column array #36657

Merged
merged 0 commits into from
Jan 4, 2021
Merged

test: add coverage for breakLength one-column array #36657

merged 0 commits into from
Jan 4, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 28, 2020

Add coverage for breakLength option resulting in a single-column array
display.

Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/util/inspect.js.html#L1277

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 28, 2020
@Trott Trott changed the title test; add coverage for breakLength one-column array test: add coverage for breakLength one-column array Dec 28, 2020
@Trott Trott requested a review from BridgeAR January 1, 2021 13:27
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35211/

@Trott
Copy link
Member Author

Trott commented Jan 4, 2021

Landed in f0fc4b8

@Trott Trott closed this Jan 4, 2021
@Trott Trott merged commit f0fc4b8 into nodejs:master Jan 4, 2021
@Trott Trott deleted the cover-me branch January 4, 2021 01:47
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Trott @danielleadams
test: add coverage for breakLength one-column array
9f7fbcc 
Add coverage for breakLength option resulting in a single-column array
display.

Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/util/inspect.js.html#L1277

PR-URL: #36657
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: add coverage for breakLength one-column array
2896219 
Add coverage for breakLength option resulting in a single-column array
display.

Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/util/inspect.js.html#L1277

PR-URL: #36657
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @jasnell @BridgeAR @Lxxyx