lib: replace public Map methods with primordials#36652
lib: replace public Map methods with primordials#36652aduh95 wants to merge 3 commits intonodejs:masterfrom
Conversation
|
Does this need to be benchmarked against |
|
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/895/ EDIT: Didn't show any perf regression or improvement 👍 Benchmark results |
|
Alternatively, it might be better to fix the C++ binding, so that |
Agreed, having to deal only with
I've been looking into that, and it seems all the C++ API does is create a Lines 275 to 277 in 7efada6 This could be done in JS, no need to change the C++, but I wouldn't be surprised if it had worse performance (haven't measured it though). |
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes