Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve coverage for util.inspect() with classes #36625

Merged
merged 1 commit into from
Dec 27, 2020
Merged

test: improve coverage for util.inspect() with classes #36625

merged 1 commit into from
Dec 27, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 25, 2020

Refs: #36622 (review)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Trott Trott requested a review from BridgeAR December 25, 2020 00:16
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 25, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35072/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35073/

@Trott
test: improve coverage for util.inspect() with classes
75afb6c 
Refs: nodejs#36622 (review)

PR-URL: nodejs#36625
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@Trott
Copy link
Member Author

Trott commented Dec 27, 2020

Landed in 75afb6c

@Trott Trott merged commit 75afb6c into nodejs:master Dec 27, 2020
@Trott Trott deleted the util-inspect-class branch December 27, 2020 04:31
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Trott @danielleadams
test: improve coverage for util.inspect() with classes
34d1d79 
Refs: #36622 (review)

PR-URL: #36625
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: improve coverage for util.inspect() with classes
581a95f 
Refs: #36622 (review)

PR-URL: #36625
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@benjamingr benjamingr benjamingr approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @benjamingr @Lxxyx @aduh95