Closed
Conversation
Signed-off-by: Michael Dawson <mdawson@devrus.com>
addaleax
approved these changes
Dec 10, 2020
Member
|
👍 to fast-track |
addaleax
added
fast-track
cjihrig
approved these changes
Dec 10, 2020
Member
Author
|
I think based on the fast track rules this can now land. Since doc only just need the linters which have passed as well. Will land. |
mhdawson
added a commit
that referenced
this pull request
Dec 10, 2020
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36475 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in 72b07e4 |
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36475 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36475 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Dawson mdawson@devrus.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes