Skip to content

Update npm 6.14.9#36450

Closed
MylesBorins wants to merge 2 commits intonodejs:v14.x-stagingfrom
MylesBorins:update-npm-6.14.9
Closed

Update npm 6.14.9#36450
MylesBorins wants to merge 2 commits intonodejs:v14.x-stagingfrom
MylesBorins:update-npm-6.14.9

Conversation

@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Dec 8, 2020

6.14.9 (2020-11-20)

BUG FIXES

  • 4a91e48aa
    fix: docs generation breaking builds

DEPENDDENCIES

@MylesBorins
tools: add update-npm script
93ecb01 
I've had to update this one too many times, and much of it can be
automated, so let's do that!

The maintenance instructions have also been updated.

PR-URL: nodejs#35822
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MylesBorins
deps: upgrade npm to 6.14.9
53deb41
@nodejs-github-bot nodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. v14.x labels Dec 8, 2020
@MylesBorins MylesBorins added request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v12.x labels Dec 8, 2020
richardlau
richardlau approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34867/

vecerek
vecerek approved these changes Dec 9, 2020
View reviewed changes
Copy link

@vecerek vecerek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2020 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34870/ ✅

@richardlau richardlau mentioned this pull request Dec 9, 2020
Closed
@BethGriggs
Copy link
Member

BethGriggs commented Dec 10, 2020

Last CI is good, (test.benchmark/test-benchmark-misc was resolved by landing #35968 on v14.x-staging)

MylesBorins added a commit that referenced this pull request Dec 10, 2020
@MylesBorins
deps: upgrade npm to 6.14.9
213583a 
PR-URL: #36450
Fixes: https://github.com/docs
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Dec 10, 2020 •
edited by BethGriggs
Loading

landed in c44b478

cherry picked to 10.x and 12.x as well

MylesBorins added a commit that referenced this pull request Dec 10, 2020
@MylesBorins
deps: upgrade npm to 6.14.9
76ea9c5 
PR-URL: #36450
Fixes: https://github.com/docs
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 10, 2020
@MylesBorins
deps: upgrade npm to 6.14.9
9c49707 
PR-URL: #36450
Fixes: https://github.com/docs
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@MylesBorins @BethGriggs
deps: upgrade npm to 6.14.9
c44b478 
PR-URL: #36450
Fixes: https://github.com/docs
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs added a commit that referenced this pull request Dec 15, 2020
@BethGriggs
2020-12-15, Version 14.15.2 'Fermium' (LTS)
2b6dd9c 
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@MylesBorins @BethGriggs
deps: upgrade npm to 6.14.9
6cea315 
PR-URL: #36450
Fixes: https://github.com/docs
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs added a commit that referenced this pull request Dec 15, 2020
@BethGriggs
2020-12-15, Version 14.15.2 'Fermium' (LTS)
a2f9a70 
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
BethGriggs added a commit that referenced this pull request Dec 15, 2020
@BethGriggs
2020-12-15, Version 14.15.2 'Fermium' (LTS)
a150926 
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@watilde watilde watilde approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

+2 more reviewers

@vecerek vecerek vecerek approved these changes

@F5in7 F5in7 F5in7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@MylesBorins @nodejs-github-bot @BethGriggs @Trott @watilde @richardlau @vecerek @F5in7