tools: update ESLint to 7.15.0 by cjihrig · Pull Request #36411 · nodejs/node

cjihrig · 2020-12-06T15:19:00Z

Update ESLint to 7.15.0 and enable the new no-unsafe-optional-chaining rule.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Update ESLint to 7.15.0

This rule is new in ESLint 7.15.0.

aduh95

RSLGTM

github-actions · 2020-12-08T16:09:42Z

Commit Queue failed

- Loading data for nodejs/node/pull/36411
✔  Done loading data for nodejs/node/pull/36411
----------------------------------- PR info ------------------------------------
Title      tools: update ESLint to 7.15.0 (#36411)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:eslint -> nodejs:master
Labels     tools
Commits    2
 - tools: update ESLint to 7.15.0
 - tools: enable no-unsafe-optional-chaining lint rule
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/36411
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36411
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ✖  No Jenkins CI runs detected
   ℹ  This PR was created on Sun, 06 Dec 2020 15:19:00 GMT
   ✔  Approvals: 4
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545715844
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545716126
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36411#pullrequestreview-545745988
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36411#pullrequestreview-547380421
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/408627427

github-actions · 2020-12-08T19:18:23Z

Commit Queue failed

- Loading data for nodejs/node/pull/36411
✔  Done loading data for nodejs/node/pull/36411
----------------------------------- PR info ------------------------------------
Title      tools: update ESLint to 7.15.0 (#36411)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:eslint -> nodejs:master
Labels     author ready, tools
Commits    2
 - tools: update ESLint to 7.15.0
 - tools: enable no-unsafe-optional-chaining lint rule
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/36411
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36411
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-12-08T17:36:33Z: https://ci.nodejs.org/job/node-test-pull-request/34850/
- Querying data for job/node-test-pull-request/34850/
✔  Build data downloaded
- Querying failures of job/node-test-commit/42841/
✔  Data downloaded
   ✖  3 failure(s) on the last Jenkins CI run
   ℹ  This PR was created on Sun, 06 Dec 2020 15:19:00 GMT
   ✔  Approvals: 4
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545715844
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545716126
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36411#pullrequestreview-545745988
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36411#pullrequestreview-547380421
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/408983371

nodejs-github-bot · 2020-12-08T19:19:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34855/

nodejs-github-bot · 2020-12-09T16:13:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34878/

github-actions · 2020-12-09T16:42:18Z

Landed in 27a63ee...a26ae70

Update ESLint to 7.15.0 PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

This rule is new in ESLint 7.15.0. PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Update ESLint to 7.15.0 PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

This rule is new in ESLint 7.15.0. PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Update ESLint to 7.15.0 PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

This rule is new in ESLint 7.15.0. PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Update ESLint to 7.15.0 PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

This rule is new in ESLint 7.15.0. PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 6, 2020

Trott approved these changes Dec 6, 2020

View reviewed changes

targos approved these changes Dec 6, 2020

View reviewed changes

lpinca approved these changes Dec 6, 2020

View reviewed changes

cjihrig added 2 commits December 8, 2020 00:29

tools: update ESLint to 7.15.0

a3a63d6

Update ESLint to 7.15.0

tools: enable no-unsafe-optional-chaining lint rule

fb102ff

This rule is new in ESLint 7.15.0.

cjihrig force-pushed the eslint branch from d9c52d8 to fb102ff Compare December 8, 2020 05:32

aduh95 approved these changes Dec 8, 2020

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020

github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 8, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2020

This comment has been minimized.

Sign in to view

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020

github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 8, 2020

jasnell approved these changes Dec 8, 2020

View reviewed changes

watilde approved these changes Dec 8, 2020

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 9, 2020

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2020

github-actions bot closed this Dec 9, 2020

cjihrig deleted the eslint branch December 9, 2020 16:43

targos mentioned this pull request Dec 22, 2020

v15.5.0 release proposal #36597

Merged

targos mentioned this pull request Jun 6, 2021

v14.17.1 release proposal #38948

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tools: update ESLint to 7.15.0#36411

tools: update ESLint to 7.15.0#36411
cjihrig wants to merge 2 commits intonodejs:masterfrom
cjihrig:eslint

cjihrig commented Dec 6, 2020

Uh oh!

aduh95 left a comment

Uh oh!

github-actions bot commented Dec 8, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 8, 2020

Uh oh!

nodejs-github-bot commented Dec 8, 2020

Uh oh!

nodejs-github-bot commented Dec 9, 2020

Uh oh!

github-actions bot commented Dec 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

cjihrig commented Dec 6, 2020

Checklist

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 8, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 8, 2020

Uh oh!

nodejs-github-bot commented Dec 8, 2020

Uh oh!

nodejs-github-bot commented Dec 9, 2020

Uh oh!

github-actions bot commented Dec 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants