test: fix child-process-pipe-dataflow#36366
Closed
santigimeno wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix child-process-pipe-dataflow#36366santigimeno wants to merge 1 commit intonodejs:masterfrom
santigimeno wants to merge 1 commit intonodejs:masterfrom
Conversation
Make sure all the `wc` process stdout data is received before checking its validity. Fixes: nodejs#25988
gireeshpunathil
approved these changes
Dec 3, 2020
Member
|
thanks @santigimeno - that looks like a very reasonable explanation to this issue. |
cjihrig
approved these changes
Dec 3, 2020
lpinca
approved these changes
Dec 3, 2020
Trott
approved these changes
Dec 6, 2020
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
gireeshpunathil
added
the
author ready
Collaborator
jasnell
approved these changes
Dec 7, 2020
gireeshpunathil
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 6d3775e...ca8eb79 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 8, 2020
Make sure all the `wc` process stdout data is received before checking its validity. Fixes: #25988 PR-URL: #36366 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
Make sure all the `wc` process stdout data is received before checking its validity. Fixes: #25988 PR-URL: #36366 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Make sure all the `wc` process stdout data is received before checking its validity. Fixes: #25988 PR-URL: #36366 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure all the
wcprocess stdout data is received before checkingits validity.
Fixes: #25988