Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: send correct error status for worker init #36242

Merged
merged 1 commit into from
Mar 19, 2021

Commits on Mar 19, 2021

  1. worker: send correct error status for worker init

    When the worker is created, in case of failure when a separate isolate
    is not able to get created, we tend to throw out of memory error for
    that worker which is not the case. Correct error code as per semantic
    should be thrown which is in our case is `ERR_WORKER_INIT_FAILED`.
    
    PR-URL: nodejs#36242
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    yashLadha authored and aduh95 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    65e8864 View commit details
    Browse the repository at this point in the history