Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: refactor to use more primordials #36211

Merged
merged 1 commit into from
Nov 25, 2020
Merged

quic: refactor to use more primordials #36211

merged 1 commit into from
Nov 25, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 21, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Nov 21, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 23, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34517/

@aduh95 @Trott
quic: refactor to use more primordials
866b1e6 
PR-URL: nodejs#36211
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott merged commit 866b1e6 into nodejs:master Nov 25, 2020
@Trott
Copy link
Member

Trott commented Nov 25, 2020

Landed in 866b1e6

@aduh95 aduh95 deleted the quic-primordials branch November 25, 2020 13:27
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@aduh95 @danielleadams
quic: refactor to use more primordials
d29199e 
PR-URL: #36211
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @Trott @joyeecheung