crypto: fix "Invalid JWK" error messages #36200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Nov 20, 2020
fhinkel
approved these changes
Nov 23, 2020
github-actions
bot
removed
the
request-ci
mcollina
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/36200 ✔ Done loading data for nodejs/node/pull/36200 ----------------------------------- PR info ------------------------------------ Title crypto: fix "Invalid JWK" error messages (#36200) Author Filip Skokan (@panva) Branch panva:fix-webcrypto-typos -> nodejs:master Labels C++ Commits 1 - crypto: fix "Invalid JWK" error messages Committers 1 - Filip Skokan PR-URL: https://github.com/nodejs/node/pull/36200 Reviewed-By: Anna Henningsen Reviewed-By: Matteo Collina Reviewed-By: Franziska Hinkelmann ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36200 Reviewed-By: Anna Henningsen Reviewed-By: Matteo Collina Reviewed-By: Franziska Hinkelmann -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-23T09:58:38Z: https://ci.nodejs.org/job/node-test-pull-request/34513/ - Querying data for job/node-test-pull-request/34513/ ✔ Build data downloaded - Querying failures of job/node-test-commit/42424/ ✔ Data downloaded ✖ 1 failure(s) on the last Jenkins CI run ℹ This PR was created on Fri, 20 Nov 2020 20:28:12 GMT ✔ Approvals: 3 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36200#pullrequestreview-535761751 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/36200#pullrequestreview-535966223 ✔ - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/36200#pullrequestreview-536306602 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/380749597 |
mcollina
added
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 219332e...4f0f2e7 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 24, 2020
PR-URL: #36200 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36200 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the typo in
webcryptoJWK import messages (JSK -> JWK)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes