Skip to content

test: remove flaky designation from ls-no-sslv3 #3620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: remove flaky designation from ls-no-sslv3 #3620

wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@Trott Trott commented Nov 1, 2015

This test was marked flaky after failing in CI on arm7-wheezy two months
ago. It has not failed there since. This commit removes the flaky
designation.

Fixes: #2554

@Trott
test: remove flaky designation from ls-no-sslv3
7ac4580 
This test was marked flaky after failing in CI on arm7-wheezy two months
ago. It has not failed there since. This commit removes the flaky
designation.

Fixes: nodejs#2554
@Trott Trott added the test Issues and PRs related to the tests. label Nov 1, 2015
@Trott Trott mentioned this pull request Nov 1, 2015
Closed
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Nov 1, 2015
@jbergstroem
Copy link
Member

LGTM

1 similar comment
@Fishrock123
Copy link
Contributor

LGTM

@Fishrock123
Copy link
Contributor

(This was one of the tests that only failed within the weird accept-pr setup)

@Trott
Copy link
Member Author

Trott commented Nov 2, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/662/

@Trott
Copy link
Member Author

Trott commented Nov 2, 2015

Landed in f6230b9

@Trott Trott closed this Nov 2, 2015
Trott added a commit that referenced this pull request Nov 2, 2015
@Trott
test: remove flaky designation from ls-no-sslv3
f6230b9 
This test was marked flaky after failing in CI on arm7-wheezy two months
ago. It has not failed there since. This commit removes the flaky
designation.

Fixes: #2554
PR-URL: #3620
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Nov 6, 2015
Closed
Trott added a commit that referenced this pull request Nov 7, 2015
@Trott @rvagg
test: remove flaky designation from ls-no-sslv3
5977963 
This test was marked flaky after failing in CI on arm7-wheezy two months
ago. It has not failed there since. This commit removes the flaky
designation.

Fixes: #2554
PR-URL: #3620
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
Merged
@MylesBorins
Copy link
Contributor

@jasnell I am imagining that commits like these would be best added just before cutting a release in order to minimize headache if there is a regression with CI. Thoughts?

@jasnell
Copy link
Member

jasnell commented Nov 16, 2015

likely a good idea

@MylesBorins MylesBorins mentioned this pull request Nov 17, 2015
Closed
Trott added a commit that referenced this pull request Dec 1, 2015
@Trott
test: remove flaky designation from ls-no-sslv3
9694983 
This test was marked flaky after failing in CI on arm7-wheezy two months
ago. It has not failed there since. This commit removes the flaky
designation.

Fixes: #2554
PR-URL: #3620
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Trott added a commit that referenced this pull request Dec 4, 2015
@Trott @rvagg
test: remove flaky designation from ls-no-sslv3
503e3e1 
This test was marked flaky after failing in CI on arm7-wheezy two months
ago. It has not failed there since. This commit removes the flaky
designation.

Fixes: #2554
PR-URL: #3620
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@jasnell jasnell mentioned this pull request Dec 17, 2015
Closed
Trott added a commit that referenced this pull request Dec 17, 2015
@Trott @jasnell
test: remove flaky designation from ls-no-sslv3
6950155 
This test was marked flaky after failing in CI on arm7-wheezy two months
ago. It has not failed there since. This commit removes the flaky
designation.

Fixes: #2554
PR-URL: #3620
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Trott added a commit that referenced this pull request Dec 23, 2015
@Trott @jasnell
test: remove flaky designation from ls-no-sslv3
16468fa 
This test was marked flaky after failing in CI on arm7-wheezy two months
ago. It has not failed there since. This commit removes the flaky
designation.

Fixes: #2554
PR-URL: #3620
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott Trott deleted the no-sslv3-not-flaky branch January 13, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott @jbergstroem @Fishrock123 @MylesBorins @jasnell @mscdex