fs: throws error if position argument is bigint in fs.readSync & fs.read

[darvesh]

Fixes #36185

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• test included
• commit message follows commit guidelines

[jasnell]

hmm... while the changes in this look good, I'm actually wondering if we shouldn't go the other way and actually allow bigints in these apis.

[darvesh]

hmm... while the changes in this look good, I'm actually wondering if we shouldn't go the other way and actually allow bigints in these apis.

As @BridgeAR mentioned here, isn't it better to let the user handle it on their own?
Also though it might be misleading since people may assume fs.read will work with offsets larger than integers which it doesn't.

[joyeecheung]

This seems to be a check that can be performed early instead of being this late? Before validateBuffer would be a good place I think.

[darvesh]

Wouldn't it be better to have arguments validation in order?

[joyeecheung]

My concern was mostly about the if (length === 0) above which means if the length is 0 you'd be able to get away with these checks..but thinking again it was already the case for a few other cases above, so it's probably not a bit deal.

[darvesh]

I think this can be closed in favour of #36190