Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inadvertent disclosure #36155

Closed
wants to merge 10 commits into from
Closed

Inadvertent disclosure #36155

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
83c1c12
doc: add process for handling premature disclosure
mhdawson Nov 17, 2020
b11e4d5
Update doc/guides/collaborator-guide.md
mhdawson Nov 18, 2020
2d2004d
fixup
mhdawson Nov 18, 2020
04c0058
squash: fixup
mhdawson Nov 18, 2020
0e2c90c
fixup
mhdawson Nov 19, 2020
9a85ac9
fixup
mhdawson Nov 19, 2020
9bc5247
Update doc/guides/collaborator-guide.md
mhdawson Nov 20, 2020
c97676c
Update doc/guides/collaborator-guide.md
mhdawson Nov 20, 2020
7e4de86
fixup[
mhdawson Nov 20, 2020
efe89c4
Update doc/guides/collaborator-guide.md
mhdawson Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions doc/guides/collaborator-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* [Closing issues and pull requests](#closing-issues-and-pull-requests)
* [Author ready pull requests](#author-ready-pull-requests)
* [Handling own pull requests](#handling-own-pull-requests)
* [Security issues](#managing-security-issues)
* [Accepting modifications](#accepting-modifications)
* [Code reviews](#code-reviews)
* [Consensus seeking](#consensus-seeking)
Expand Down Expand Up @@ -87,6 +88,33 @@ to land but is [author ready](#author-ready-pull-requests), add the
`author ready` label. If you wish to land the pull request yourself, use the
"assign yourself" link to self-assign it.

### Managing security issues

Security issues should ideally be reported through the processes outlined in
[SECURITY.md][security reporting]. This allows the collaborators to
appropriately triage the report and address vulnerabilities in a planned
security release. If an issue is opened in the public repo
which describes a security issue, or if an issue is later identified to be
describing a security issue, take the following steps:

* Ask the originator to submit a report through Hacker one as outlined in
[SECURITY.md][security reporting].
* Move the issue to the private repo called `premature-disclosures`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the repository? Or should we keep it without a link on purpose?

Also, I assume it will be a repo on nodejs-private?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not created the repo yet, but a link makes sense. It should only be accessible to those who have access to private repos within the org

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmarchini added the link in the first reference, not sure if we need to make all references a link or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I assume it will be a repo on nodejs-private?

No, its a private repo in the nodejs org as I don't believe we can move issues across organizations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. The downside is that folks who have access to private repos in this org but not on the repo we usually use for security releases will have access to the issue. It's probably fine though, it only means some folks in moderation and CommComm will have access to the issue even when they don't have access to security release discussions (which is still better than keeping the issue public).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmarchini

which is still better than keeping the issue public

+1

mhdawson marked this conversation as resolved.
Show resolved Hide resolved
* For any related pull requests create an associated issue in the
`premature-disclosures` repo and add a copy of the patch for the
pull request, and screenshots of discussion on the PR to the issue.
* Open a ticket with GitHub asking that the PRs be deleted through
[GitHub suppport](https://support.github.com/contact)
using Node.js(team) as the account organization.
* Open a new issue in the repository in which the issue was originally
reported with a brief FYI to the originator. `FYI @xxxx we asked github
to delete your PR while we work on releases in private.` with the title
`FYI - PR deleted #YYYY`.
* Email `tsc@iojs.org` with the link to the issues in the
`premature-disclosures` repo so that the TSC is aware that they
may need to expidite handling of the issue due to premature
mhdawson marked this conversation as resolved.
Show resolved Hide resolved
disclosure.

## Accepting modifications

Contributors propose modifications to Node.js using GitHub pull requests. This
Expand Down Expand Up @@ -792,3 +820,4 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` can help.
[node-core-utils-credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials
[node-core-utils-issues]: https://github.com/nodejs/node-core-utils/issues
[unreliable tests]: https://github.com/nodejs/node/issues?q=is%3Aopen+is%3Aissue+label%3A%22CI+%2F+flaky+test%22
[security reporting]: https://github.com/nodejs/SECURITY.md