crypto: API doc spkac fix #3614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regarding description of the following functions: Certificate.exportPublicKey(spkac) Certificate.exportChallenge(spkac) The descriptions were applied incorrectly.
mscdex
added
crypto
bnoordhuis
pushed a commit
that referenced
this pull request
Nov 1, 2015
Fix regarding description of the following functions: Certificate.exportPublicKey(spkac) Certificate.exportChallenge(spkac) The descriptions were applied incorrectly. PR-URL: #3614 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks, landed in 9e3aa45. I used your full name ("Author" originally was "jas-") and I took the liberty of rewriting the first line of the commit log, hope you don't mind; changes to doc/ usually get the |
|
Noted, thanks. |
rvagg
pushed a commit
that referenced
this pull request
Nov 7, 2015
Fix regarding description of the following functions: Certificate.exportPublicKey(spkac) Certificate.exportChallenge(spkac) The descriptions were applied incorrectly. PR-URL: #3614 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
|
landed in v4.x-staging as b3b55a5 |
mhdawson
pushed a commit
to mhdawson/io.js
that referenced
this pull request
Nov 17, 2015
Fix regarding description of the following functions: Certificate.exportPublicKey(spkac) Certificate.exportChallenge(spkac) The descriptions were applied incorrectly. PR-URL: nodejs#3614 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg
pushed a commit
that referenced
this pull request
Dec 4, 2015
Fix regarding description of the following functions: Certificate.exportPublicKey(spkac) Certificate.exportChallenge(spkac) The descriptions were applied incorrectly. PR-URL: #3614 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Closed
jasnell
pushed a commit
that referenced
this pull request
Dec 17, 2015
Fix regarding description of the following functions: Certificate.exportPublicKey(spkac) Certificate.exportChallenge(spkac) The descriptions were applied incorrectly. PR-URL: #3614 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell
pushed a commit
that referenced
this pull request
Dec 23, 2015
Fix regarding description of the following functions: Certificate.exportPublicKey(spkac) Certificate.exportChallenge(spkac) The descriptions were applied incorrectly. PR-URL: #3614 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regarding description of the following functions:
Certificate.exportPublicKey(spkac)
Certificate.exportChallenge(spkac)
The descriptions were applied incorrectly.