Skip to content

src: use MaybeLocal.ToLocal instead of IsEmpty #35716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: use MaybeLocal.ToLocal instead of IsEmpty #35716

wants to merge 1 commit into from

Conversation

@danbev
Copy link
Contributor

@danbev danbev commented Oct 20, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Oct 20, 2020
@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #35716 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #35716   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         220      220           
  Lines       73676    73676           
=======================================
+ Hits        71027    71030    +3     
+ Misses       2649     2646    -3
Impacted Files Coverage Δ
lib/internal/util/inspect.js 96.14% <0.00%> (+0.09%) ⬆️
lib/_http_server.js 98.55% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50103bf...f2016af. Read the comment docs.

targos
targos reviewed Oct 20, 2020
View reviewed changes
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 22, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33798/

danbev added a commit that referenced this pull request Oct 26, 2020
@danbev
src: use MaybeLocal.ToLocal instead of IsEmpty
ba465c5 
PR-URL: #35716
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danbev
Copy link
Contributor Author

danbev commented Oct 26, 2020

Landed in ba465c5.

@danbev danbev closed this Oct 26, 2020
@danbev danbev deleted the buffer-tolocalchecked branch October 26, 2020 11:38
targos pushed a commit that referenced this pull request Nov 3, 2020
@danbev @targos
src: use MaybeLocal.ToLocal instead of IsEmpty
4b8b5fe 
PR-URL: #35716
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@danbev @BethGriggs
src: use MaybeLocal.ToLocal instead of IsEmpty
99cf2eb 
PR-URL: #35716
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@danbev @BethGriggs
src: use MaybeLocal.ToLocal instead of IsEmpty
e8fd3ec 
PR-URL: #35716
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@danbev @BethGriggs
src: use MaybeLocal.ToLocal instead of IsEmpty
34c870e 
PR-URL: #35716
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments

@targos targos targos left review comments

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

+2 more reviewers

@devnexen devnexen devnexen approved these changes

@crypt096 crypt096 crypt096 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@danbev @codecov-io @nodejs-github-bot @Trott @addaleax @targos @cjihrig @devnexen @richardlau @crypt096