Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use make functions instead of echo #35707

Merged
merged 1 commit into from
Oct 21, 2020
Merged

build: use make functions instead of echo #35707

merged 1 commit into from
Oct 21, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 19, 2020

This PR replaces echo calls by built-in Make functions. I can see several advantages for doing that:

  • It states more clearly what is the intent (is it a warning? is it just an info?).
  • It outputs warnings and error messages to stderr instead of stdout.
  • It prints line number for warnings and errors, which may help collaborator to understand what's happening.
  • We have several deprecated build targets that are effectively aliases to other targets. It eases the process of deprecation if we were to deprecate them by changing warning to error.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 19, 2020
Trott
Trott reviewed Oct 19, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Oct 19, 2020

@nodejs/build-files

Trott
Trott approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if there are no unexpected Jenkins implications or anything like that

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33719/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 19, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33748/

@aduh95 @Trott
build: use make functions instead of echo
a987a32 
PR-URL: nodejs#35707
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 21, 2020

Landed in a987a32

@Trott Trott merged commit a987a32 into nodejs:master Oct 21, 2020
@aduh95 aduh95 deleted the use-make-functions branch October 21, 2020 12:34
BethGriggs pushed a commit that referenced this pull request Oct 21, 2020
@aduh95 @BethGriggs
build: use make functions instead of echo
c509485 
PR-URL: #35707
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@aduh95 @BethGriggs
build: use make functions instead of echo
988066f 
PR-URL: #35707
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@aduh95 @BethGriggs
build: use make functions instead of echo
06f88ab 
PR-URL: #35707
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@aduh95 @BethGriggs
build: use make functions instead of echo
6c61b93 
PR-URL: #35707
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @Trott @nodejs-github-bot @lpinca @richardlau