Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x] Revert "tools: add missing uv_setup_argv() calls" #35641

Closed
wants to merge 1 commit into from
Closed

[v14.x] Revert "tools: add missing uv_setup_argv() calls" #35641

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

test-asan is failing on v14.x. I suspect it is due to this commit - I'm raising this PR to initially just test whether this commit is the cause of the failure (I'm having trouble running test-asan locally).

The original PR passed test-asan, so I suspect if this commit is the cause, it would be due to a related commit missing on v14.x.

This reverts commit 70e77f123164ecbdbdd4abc2e4919ce1b193421e.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@BethGriggs
Revert "tools: add missing uv_setup_argv() calls"
c9b5b56 
This reverts commit 70e77f123164ecbdbdd4abc2e4919ce1b193421e.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added tools Issues and PRs related to the tools directory. v14.x labels Oct 14, 2020
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2020
Closed
4 tasks
@BethGriggs
Copy link
Member Author

Looks like it is this commit as test-asan has passed. @nodejs/release what do you think we should do here? Revert the commit and re-land once we've figured out which other commits need to land alongside it?

/cc @richardlau @addaleax

@addaleax
Copy link
Member

I think reverting this on v14.x only is fine as long as it passes CI :)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33618/

@BethGriggs BethGriggs marked this pull request as ready for review October 14, 2020 14:51
BethGriggs added a commit that referenced this pull request Oct 14, 2020
@BethGriggs
Revert "tools: add missing uv_setup_argv() calls"
bd34410 
This reverts commit 70e77f123164ecbdbdd4abc2e4919ce1b193421e.

Refs: #35491

PR-URL: #35641
Reviewed-By: Richard Lau <rlau@redhat.com>
@BethGriggs
Copy link
Member Author

Landed in bd34410

@BethGriggs BethGriggs closed this Oct 14, 2020
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
XadillaX
XadillaX reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XadillaX XadillaX XadillaX left review comments

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BethGriggs @nodejs-github-bot @addaleax @XadillaX @richardlau