Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update url test for win #35622

Closed
wants to merge 2 commits into from
Closed

test: update url test for win #35622

wants to merge 2 commits into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Oct 12, 2020 •
edited
Loading

Follow up PR to #35477 (comment).

Fixes: #35621

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2020
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2020
@watilde watilde assigned Flarna and unassigned Flarna Oct 12, 2020
@watilde watilde requested a review from Flarna October 12, 2020 23:19
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33556/

@watilde
Copy link
Member Author

watilde commented Oct 13, 2020 •
edited
Loading

I'm checking this result on Windows now: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/6160/testReport/

Tests in cc have been fixed.

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33557/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33559/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33561/

@Flarna
Copy link
Member

Flarna commented Oct 13, 2020

I can build and run on windows locally if it helps. What I found is that the change seems to be problematic.

experimentalPolicy looks like this: C:\workspaces\GitHubForks\node\test\fixtures\policy\dependencies\dependencies-redirect-policy.json
path.isAbsolut() correctly returns true.
But the resulting manifestURL is c:\workspaces\GitHubForks\node\test\fixtures\policy\dependencies\dependencies-redirect-policy.json which seems to be wrong.

@watilde
Copy link
Member Author

watilde commented Oct 13, 2020 •
edited
Loading

@Flarna Thank you for your warm help and for pointing the line. I just updated the line to force using the file protocol which is what we had and tests passed in my local with WSL2. Will trigger CI again to see if this fixes the Windows case.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33562/

@watilde
Copy link
Member Author

watilde commented Oct 13, 2020

The latest CI result seems to be all green: https://ci.nodejs.org/job/node-test-pull-request/33562/. Thank you @Flarna for your help!

Flarna
Flarna approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the commit message of the second commit should be changes as bootstrap was modified, not inspector.

@watilde
Copy link
Member Author

watilde commented Oct 13, 2020

That's right, I just updated the subsystem in the commit message to bootstrap, thank you.

I think the commit message of the second commit should be changes as bootstrap was modified, not inspector.

@Flarna Flarna mentioned this pull request Oct 13, 2020
Closed
2 tasks
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33564/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33566/

@Flarna Flarna added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Oct 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33570/

@Trott
Copy link
Member

Trott commented Oct 13, 2020

If this fixes CI on master, should it be fast-tracked?

@Flarna Flarna added fast-track PRs that do not need to wait for 48 hours to land. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 13, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2020
@github-actions
Copy link
Contributor

Landed in 0aa2c5b...8a12e99

@github-actions github-actions bot closed this Oct 13, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 13, 2020
@watilde @nodejs-github-bot
test: update url test for win
9f2e19f 
PR-URL: #35622
Fixes: #35621
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit that referenced this pull request Oct 13, 2020
@watilde @nodejs-github-bot
bootstrap: use file URL instead of relative url
8a12e99 
PR-URL: #35622
Fixes: #35621
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@watilde watilde deleted the test-url-win branch October 13, 2020 13:27
@Trott
Copy link
Member

Trott commented Oct 13, 2020 •
edited
Loading

Unfortunately, the bot didn't squash the two commits into one so we have a broken commit on master. Probably not a big deal in this particular instance, but not something I want happening regularly. I guess we need to socialize using --fixup commits more often, or at least avoiding adding in subsystem: message formatted commits unless we don't want them squashed? @mmarchini

@watilde watilde mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@watilde @joesepi
test: update url test for win
8ce9cb8 
PR-URL: nodejs#35622
Fixes: nodejs#35621
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@watilde @joesepi
bootstrap: use file URL instead of relative url
d0eef8d 
PR-URL: nodejs#35622
Fixes: nodejs#35621
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe left review comments

@Flarna Flarna Flarna approved these changes

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI fails on master
6 participants
@watilde @nodejs-github-bot @Flarna @Trott @bcoe @richardlau