Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve SIGINT error text #35558

Merged
merged 1 commit into from
Oct 10, 2020
Merged

doc: improve SIGINT error text #35558

merged 1 commit into from
Oct 10, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 8, 2020

  • add kbd elements
  • correct period/parenthesis order
  • make fragment a full sentence
Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Oct 8, 2020
@Trott
Copy link
Member Author

Trott commented Oct 8, 2020

Before:

image

After:

image

@Trott
doc: improve SIGINT error text
91f0544 
* add kbd elements
* correct period/parenthesis order
* make fragment a full sentence

PR-URL: nodejs#35558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@Trott Trott merged commit 91f0544 into nodejs:master Oct 10, 2020
@Trott
Copy link
Member Author

Trott commented Oct 10, 2020

Landed in 91f0544

@Trott Trott deleted the sigint branch October 10, 2020 12:17
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@Trott @MylesBorins
doc: improve SIGINT error text
c865b02 
* add kbd elements
* correct period/parenthesis order
* make fragment a full sentence

PR-URL: #35558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@Trott @MylesBorins
doc: improve SIGINT error text
7eeac48 
* add kbd elements
* correct period/parenthesis order
* make fragment a full sentence

PR-URL: #35558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@Trott @MylesBorins
doc: improve SIGINT error text
05db4b8 
* add kbd elements
* correct period/parenthesis order
* make fragment a full sentence

PR-URL: #35558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: improve SIGINT error text
84f3768 
* add kbd elements
* correct period/parenthesis order
* make fragment a full sentence

PR-URL: nodejs#35558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @addaleax @Flarna @nodejs-github-bot