Skip to content

test: split independent tests into separate files #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

test: split independent tests into separate files #3548

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 27, 2015

Move ENOENT related tests out of general fs.watch() test file and into its own file. This may help diagnose #3541.

/cc @jbergstroem @cjihrig @charlierudolph

@targos targos added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. labels Oct 27, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Oct 27, 2015

LGTM. Let's see how the CI feels.

@targos
Copy link
Member

targos commented Oct 27, 2015

You can constify the file. Apart from that, LGTM.

@Trott
Copy link
Member Author

Trott commented Oct 27, 2015

Constified, thanks!

CI: https://ci.nodejs.org/job/node-test-pull-request/632/

@jbergstroem
Copy link
Member

LGTM

Trott added a commit that referenced this pull request Oct 28, 2015
@Trott
test: split independent tests into separate files
26e47ef 
Move ENOENT related tests out of general fs.watch() test file and into
its own file. This may help diagnose
#3541.

PR-URL: #3548
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Trott
Copy link
Member Author

Trott commented Oct 28, 2015

Landed in 26e47ef

@Trott Trott closed this Oct 28, 2015
rvagg pushed a commit to rvagg/io.js that referenced this pull request Oct 29, 2015
@Trott @rvagg
test: split independent tests into separate files
74e2328 
Move ENOENT related tests out of general fs.watch() test file and into
its own file. This may help diagnose
nodejs#3541.

PR-URL: nodejs#3548
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This was referenced Oct 29, 2015
Merged
Closed
Trott added a commit that referenced this pull request Oct 30, 2015
@Trott @jasnell
test: split independent tests into separate files
1c169a0 
Move ENOENT related tests out of general fs.watch() test file and into
its own file. This may help diagnose
#3541.

PR-URL: #3548
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@jasnell
Copy link
Member

jasnell commented Oct 30, 2015

Landed in v4.x-staging in 1c169a0

Trott added a commit that referenced this pull request Oct 30, 2015
@Trott @jasnell
test: split independent tests into separate files
c563a34 
Move ENOENT related tests out of general fs.watch() test file and into
its own file. This may help diagnose
#3541.

PR-URL: #3548
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Trott Trott deleted the test-fs-watch branch January 13, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @cjihrig @targos @jbergstroem @jasnell