Skip to content

doc: fix conditional exports flag removal version#35428

Closed
aduh95 wants to merge 1 commit intonodejs:masterfrom
aduh95:fix-conditional-exports-flag-removal-version
Closed

doc: fix conditional exports flag removal version#35428
aduh95 wants to merge 1 commit intonodejs:masterfrom
aduh95:fix-conditional-exports-flag-removal-version

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 30, 2020 •
edited
Loading

v12.15.0 was a security release, conditional exports flag removal was actually backported in v12.16.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2020

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 30, 2020
MylesBorins
MylesBorins approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 30, 2020
@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 30, 2020

fast-track?

mcollina
mcollina approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and +1 to fast-track

@aduh95 aduh95 mentioned this pull request Oct 2, 2020
Closed
3 tasks
lpinca pushed a commit that referenced this pull request Oct 4, 2020
@aduh95 @lpinca
doc: fix conditional exports flag removal version
5c5d044 
PR-URL: #35428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca
Copy link
Member

lpinca commented Oct 4, 2020

Landed in 5c5d044.

@lpinca lpinca closed this Oct 4, 2020
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@aduh95 @danielleadams
doc: fix conditional exports flag removal version
3f95440 
PR-URL: #35428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
@aduh95 aduh95 mentioned this pull request Oct 23, 2020
Closed
3 tasks
aduh95 added a commit to aduh95/node that referenced this pull request Oct 23, 2020
@aduh95
doc: fix conditional exports flag removal version
e1958d5 
PR-URL: nodejs#35428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@aduh95 @MylesBorins
doc: fix conditional exports flag removal version
6d660aa 
Backport-PR-URL: #35757
PR-URL: #35428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@aduh95 @MylesBorins
doc: fix conditional exports flag removal version
a7e66b6 
Backport-PR-URL: #35757
PR-URL: #35428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@aduh95 @joesepi
doc: fix conditional exports flag removal version
012a4d9 
PR-URL: nodejs#35428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 deleted the fix-conditional-exports-flag-removal-version branch July 16, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

+1 more reviewer

@MylesBorins MylesBorins MylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95 @nodejs-github-bot @MylesBorins @lpinca @mcollina @jasnell @Trott @addaleax