Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix fs.promises.writeFile with typed arrays #35376

Closed
wants to merge 1 commit into from
Closed

fs: fix fs.promises.writeFile with typed arrays #35376

wants to merge 1 commit into from

Commits on Sep 27, 2020

  1. fs: fix fs.promises.writeFile with typed arrays 

    Before this change, only the first part of typed arrays which have more
than 1 byte per element (e.g. Uint16Array) would be written.
This also removes the use of the `slice` method to avoid unnecessary
copying the data.

Fixes: nodejs#35343
    @targos
    targos committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    5c604bc View commit details
    Browse the repository at this point in the history