Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: only apply drain listener if given callback #3534

Closed
wants to merge 3 commits into from
Closed

zlib: only apply drain listener if given callback #3534

wants to merge 3 commits into from

Commits on Nov 13, 2015

  1. zlib: pass kind to recursive calls to flush 

    Bug spotted by @bnoordhuis while doing code review on #3534

#3534 (comment)
    Myles Borins committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    ce8a3e1 View commit details
    Browse the repository at this point in the history

  2. zlib: only apply drain listener if given callback 

    When stream.flush() is called without a callback, an empty listener is
being added. Since flush may be called multiple times to push SSE's
down to the client, multiple noop listeners are being added. This in
turn causes the memory leak detected message.
    @CraigCav
    CraigCav authored and Myles Borins committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    599e48d View commit details
    Browse the repository at this point in the history

  3. test: add test-zlib-flush-drain 

    This test assures that if flush is called while the zlib object needs
to be drained that it will defer the callback until after the drain.
    Myles Borins committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    0d62987 View commit details
    Browse the repository at this point in the history