repl: standardize Control key indications#35270
Merged
Trott merged 1 commit intonodejs:masterfrom Sep 28, 2020
Merged
Conversation
Trott
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
I'm not sure if our markdown renderer supports this but Ctrl + C would be nice. If it doesn't we can also do it manually: https://snek.dev/keyboard.html |
Trott
force-pushed
the
repl-Ctrl-plus
branch
from
51bf656 to
9a1c996
Compare
Member
Author
I like a lot of things about that approach, but I am somewhat conflicted and would prefer to keep the "standardize the abbreviation we use for the Control key" separate from "figure out how we render/markup keyboard keys". I'd be happy to open a different PR for that second one, unless you want to do it. |
Member
Author
|
@nodejs/documentation |
Member
Author
|
@nodejs/repl |
BridgeAR
approved these changes
Sep 22, 2020
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM, those are definitely clearer than e.g., ^C :-)
aymen94
approved these changes
Sep 24, 2020
github-actions
bot
removed
the
request-ci
Collaborator
Throughout our messages and docs, we refer to the Control key in a surprisingly varied number of ways: * Control * Ctrl * Cntl * varied capitalization on the above (e.g., ctrl vs. Ctrl) Then, in key combinations: * One of the items from the previous list followed by `-` * ... or followed by `+` * ... surrounded or not by `<` and `>` * ... and inside backticks or not * ... or just `^` This is the start of standardization on the formulation recommended by the Microsoft Style Guide (e.g., **Ctrl+C**). PR-URL: nodejs#35270 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott
force-pushed
the
repl-Ctrl-plus
branch
from
9a1c996 to
eec4a5b
Compare
Member
Author
|
Landed in eec4a5b |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 29, 2020
Throughout our messages and docs, we refer to the Control key in a surprisingly varied number of ways: * Control * Ctrl * Cntl * varied capitalization on the above (e.g., ctrl vs. Ctrl) Then, in key combinations: * One of the items from the previous list followed by `-` * ... or followed by `+` * ... surrounded or not by `<` and `>` * ... and inside backticks or not * ... or just `^` This is the start of standardization on the formulation recommended by the Microsoft Style Guide (e.g., **Ctrl+C**). PR-URL: #35270 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Throughout our messages and docs, we refer to the Control key in a surprisingly varied number of ways: * Control * Ctrl * Cntl * varied capitalization on the above (e.g., ctrl vs. Ctrl) Then, in key combinations: * One of the items from the previous list followed by `-` * ... or followed by `+` * ... surrounded or not by `<` and `>` * ... and inside backticks or not * ... or just `^` This is the start of standardization on the formulation recommended by the Microsoft Style Guide (e.g., **Ctrl+C**). PR-URL: nodejs#35270 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throughout our messages and docs, we refer to the Control key in a
surprisingly varied number of ways:
Then, in key combinations:
-+<and>^This is the start of standardization on the formulation recommended by
the Microsoft Style Guide (e.g., Ctrl+C).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes