Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: sort repl references in ASCII order #35230

Merged
merged 1 commit into from
Sep 19, 2020
Merged

doc: sort repl references in ASCII order #35230

merged 1 commit into from
Sep 19, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 16, 2020

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Sep 16, 2020
@aduh95
Copy link
Contributor

aduh95 commented Sep 16, 2020

If that's something we want to enforce, should we create a test for this?

@Trott
Copy link
Member Author

Trott commented Sep 16, 2020

If that's something we want to enforce, should we create a test for this?

A test or a lint rule would be great IMO. Every time I open one of these PRs, I think about a lint rule, but realistically I don't think I'll ever actually do it. So if you feel motivated, by all means, please do!

@aduh95 aduh95 mentioned this pull request Sep 17, 2020
Merged
4 tasks
@Trott
doc: sort repl references in ASCII order
4c5bb1a 
PR-URL: nodejs#35230
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented Sep 19, 2020

Landed in 4c5bb1a

@Trott Trott merged commit 4c5bb1a into nodejs:master Sep 19, 2020
@Trott Trott deleted the repl-sort branch September 19, 2020 13:09
ruyadorno pushed a commit that referenced this pull request Sep 21, 2020
@Trott @ruyadorno
doc: sort repl references in ASCII order
b9161f4 
PR-URL: #35230
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: sort repl references in ASCII order
e026ce9 
PR-URL: #35230
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: sort repl references in ASCII order
b8f1088 
PR-URL: nodejs#35230
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHeer MrHeer MrHeer approved these changes

@trivikr trivikr trivikr approved these changes

@shisama shisama shisama approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @aduh95 @addaleax @lpinca @watilde @shisama @trivikr @MrHeer @nodejs-github-bot