Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only set keep-alive when not exists #35096

Closed
wants to merge 0 commits into from
Closed

fix: only set keep-alive when not exists #35096

wants to merge 0 commits into from

Conversation

atian25
Copy link
Contributor

@atian25 atian25 commented Sep 8, 2020 •
edited
Loading

  • only set Keep-Alive once
  • set Keep-Alive with correct ms

fix: #34561 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@atian25 atian25 requested a review from a team as a code owner September 8, 2020 07:41
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Sep 8, 2020
@atian25 atian25 mentioned this pull request Sep 8, 2020
Closed
4 tasks
@atian25 atian25 force-pushed the master branch 2 times, most recently from 30638d4 to f3f40c3 Compare September 8, 2020 07:59
@atian25 atian25 mentioned this pull request Sep 8, 2020
Merged
4 tasks
rickyes
rickyes approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@rickyes rickyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2020
ronag
ronag reviewed Sep 8, 2020
View reviewed changes
lib/_http_outgoing.js Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33098/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33100/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33104/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 9, 2020 •
edited by rickyes
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33106/ ✅

@pull pull bot closed this Sep 10, 2020
This was referenced Sep 10, 2020
Closed
Closed
@atian25 atian25 mentioned this pull request Oct 10, 2020
Closed
4 tasks
@wedataintelligence wedataintelligence mentioned this pull request Nov 30, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 30, 2023
Open
@baby636 baby636 mentioned this pull request Dec 1, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 13, 2024
Open
@molllyn1 molllyn1 mentioned this pull request May 13, 2024
Open
@ron-a20 ron-a20 mentioned this pull request May 13, 2024
Open
@137717unity 137717unity mentioned this pull request May 14, 2024
Open
@baby636 baby636 mentioned this pull request May 14, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request May 14, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@rickyes rickyes rickyes approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atian25 @nodejs-github-bot @lpinca @ronag @rickyes