Revert "build: require "allow edits" to be checked"#35094
Merged
Trott merged 1 commit intonodejs:masterfrom Sep 8, 2020
Merged
Revert "build: require "allow edits" to be checked"#35094Trott merged 1 commit intonodejs:masterfrom
Trott merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
meta
Member
Author
|
I think there's consensus to revert? @addaleax @ljharb @mmarchini @richardlau |
Member
|
Yes, it seems that without the tooling being updated to differentiate between required and optional status checks, and without consensus that requiring this default-on checkbox to remain checked is appropriate, it's best to remove the check for now. |
mmarchini
approved these changes
Sep 7, 2020
Contributor
|
Fast track? |
richardlau
approved these changes
Sep 8, 2020
richardlau
added
the
fast-track
Member
Author
|
Landed in 6f2af08 |
This reverts commit 07423b5. Refs: nodejs#35002 (comment) PR-URL: nodejs#35094 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2020
This reverts commit 07423b5. Refs: #35002 (comment) PR-URL: #35094 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
This reverts commit 07423b5. Refs: nodejs#35002 (comment) PR-URL: nodejs#35094 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 07423b5.
Refs: #35002 (comment)
Checklist