Skip to content

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Sep 4, 2020

Refs: #34600

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Sep 4, 2020
@tniessen tniessen force-pushed the doc-add-link-to-safe-integers branch from 380d45f to bb39e3e Compare September 4, 2020 15:37
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2020
@Trott Trott force-pushed the doc-add-link-to-safe-integers branch from 7b7b6f2 to cc60347 Compare September 6, 2020 23:22
Refs: nodejs#34600
Co-authored-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#35049
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member

Trott commented Sep 6, 2020

Landed in cc60347

@Trott Trott merged commit cc60347 into nodejs:master Sep 6, 2020
richardlau pushed a commit that referenced this pull request Sep 7, 2020
Refs: #34600
Co-authored-by: Rich Trott <rtrott@gmail.com>

PR-URL: #35049
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@richardlau richardlau mentioned this pull request Sep 7, 2020
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
Refs: #34600
Co-authored-by: Rich Trott <rtrott@gmail.com>

PR-URL: #35049
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Refs: #34600
Co-authored-by: Rich Trott <rtrott@gmail.com>

PR-URL: #35049
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Refs: nodejs#34600
Co-authored-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#35049
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants