doc: fixing typos in Buffer doc.#34981
Closed
robhybrid wants to merge 3 commits intonodejs:masterfrom
robhybrid:master
Closed
doc: fixing typos in Buffer doc.#34981robhybrid wants to merge 3 commits intonodejs:masterfrom robhybrid:master
robhybrid wants to merge 3 commits intonodejs:masterfrom
robhybrid:master
Conversation
nodejs-github-bot
added
buffer
DerekNonGeneric
approved these changes
Aug 30, 2020
Trott
approved these changes
Aug 30, 2020
robhybrid
changed the title
benjamingr
approved these changes
Aug 30, 2020
Trott
pushed a commit
that referenced
this pull request
Sep 1, 2020
* pluralize "strings" in hex encoding description. * fix typo in ascii encoding description * remove double "array" PR-URL: #34981 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Member
|
Landed in 59cad32. Thanks for the contribution! 🎉 |
richardlau
pushed a commit
that referenced
this pull request
Sep 1, 2020
* pluralize "strings" in hex encoding description. * fix typo in ascii encoding description * remove double "array" PR-URL: #34981 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Sep 3, 2020
* pluralize "strings" in hex encoding description. * fix typo in ascii encoding description * remove double "array" PR-URL: #34981 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
* pluralize "strings" in hex encoding description. * fix typo in ascii encoding description * remove double "array" PR-URL: #34981 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
* pluralize "strings" in hex encoding description. * fix typo in ascii encoding description * remove double "array" PR-URL: #34981 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc: fixing typos in Buffer doc.
Checklist