Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use links to MS guide in style guide #34871

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 21, 2020

Avoid repeating too much from the Microsoft guide by providing links to
it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Avoid repeating too much from the Microsoft guide by providing links to
it.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 21, 2020
@aduh95
Copy link
Contributor

aduh95 commented Aug 22, 2020

Should we be worried of MS changing URLs which would break these links? Or maybe changing the rules? IMHO having the rules repeated in our docs is less risky and more reliable.

@Trott
Copy link
Member Author

Trott commented Aug 22, 2020

Should we be worried of MS changing URLs which would break these links? Or maybe changing the rules? IMHO having the rules repeated in our docs is less risky and more reliable.

I'm OK dealing with it when if/when it happens.

@Trott Trott added the review wanted PRs that need reviews. label Aug 24, 2020
Trott added a commit that referenced this pull request Aug 25, 2020
Avoid repeating too much from the Microsoft guide by providing links to
it.

PR-URL: #34871
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member Author

Trott commented Aug 25, 2020

Landed in b93325c

@Trott Trott closed this Aug 25, 2020
richardlau pushed a commit that referenced this pull request Sep 1, 2020
Avoid repeating too much from the Microsoft guide by providing links to
it.

PR-URL: #34871
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@richardlau richardlau mentioned this pull request Sep 2, 2020
4 tasks
@Trott Trott deleted the linkit branch April 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants