Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve async_hooks snippets #34829

Closed
wants to merge 1 commit into from
Closed

doc: improve async_hooks snippets #34829

wants to merge 1 commit into from

Conversation

puzpuzpuz
Copy link
Member

Some fs.writeSync calls in snippets were using 1 instead of process.stdout.fd.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Aug 18, 2020
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 18, 2020
@jasnell
Copy link
Member

jasnell commented Aug 18, 2020

fast-track?

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 18, 2020
@jasnell
Copy link
Member

jasnell commented Aug 18, 2020

Landed in f39a121

@jasnell jasnell closed this Aug 18, 2020
jasnell pushed a commit that referenced this pull request Aug 18, 2020
@puzpuzpuz @jasnell
doc: improve async_hooks snippets
f39a121 
PR-URL: #34829
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@puzpuzpuz @BethGriggs
doc: improve async_hooks snippets
963bbec 
PR-URL: #34829
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@puzpuzpuz @BethGriggs
doc: improve async_hooks snippets
969fb1c 
PR-URL: #34829
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@puzpuzpuz @addaleax
doc: improve async_hooks snippets
d1c9afa 
PR-URL: #34829
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@puzpuzpuz @addaleax
doc: improve async_hooks snippets
3abcc74 
PR-URL: #34829
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@RaisinTen RaisinTen mentioned this pull request Apr 24, 2021
Closed
This was referenced May 27, 2022
Open
Open
@137717unity 137717unity mentioned this pull request May 27, 2022
Open
@baby636 baby636 mentioned this pull request May 27, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request May 27, 2022
Open
@ron-a20 ron-a20 mentioned this pull request May 27, 2022
Open
@molllyn1 molllyn1 mentioned this pull request May 28, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@kissofire kissofire mentioned this pull request Jun 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@puzpuzpuz @jasnell @benjamingr @Flarna @nodejs-github-bot