lib: add UNC support to url.pathToFileURL()#34743
Closed
mceachen wants to merge 2 commits intonodejs:masterfrom
mceachen:master
Closed
lib: add UNC support to url.pathToFileURL()#34743mceachen wants to merge 2 commits intonodejs:masterfrom mceachen:master
mceachen wants to merge 2 commits intonodejs:masterfrom
mceachen:master
Conversation
guybedford
approved these changes
Aug 12, 2020
jasnell
approved these changes
Aug 12, 2020
Contributor
Author
|
Seems like |
Collaborator
Member
|
@mceachen ... yeah, that's a known issue. A fix is pending. |
lpinca
reviewed
Aug 12, 2020
lib/internal/url.js
Outdated
| function encodePathChars(filepath) { | ||
| if (filepath.includes('%')) | ||
| filepath = filepath.replace(percentRegEx, '%25'); | ||
| // In posix, "/" is a valid character in paths |
Member
There was a problem hiding this comment.
Suggested change
| // In posix, "/" is a valid character in paths | |
| // In posix, "\" is a valid character in paths |
Contributor
Author
There was a problem hiding this comment.
Ah, good catch. I just moved this comment, btw, when I refactored out the function. Will fix.
lpinca
approved these changes
Aug 12, 2020
fix mistake in comment
Contributor
Author
|
Thanks for the reviews! Is there anything else I need to do for this PR? (I haven't committed to this project before). |
Collaborator
Trott
approved these changes
Aug 14, 2020
Member
|
Landed in 7b8c6b0. Thanks for the contribution! 🎉 |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #34736
Checklist
make -j4 test(UNIX) passesvcbuild test(Windows) passes