meta: add TSC as owner of governance-related docs #34737

mmarchini · 2020-08-11T21:25:20Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2020-08-11T21:25:24Z

Review requested:

@nodejs/tsc

mmarchini · 2020-08-11T21:26:03Z

Also @nodejs/community-committee since this PR will add you as owner of some files :)

jasnell · 2020-08-11T21:42:02Z

Likely good to include LICENSE in there as well?

mmarchini · 2020-08-11T21:48:09Z

Right, missed that one

bnb · 2020-08-11T22:40:24Z

Appreciate you actively including CommComm ❤️

MylesBorins

LGTM

MylesBorins · 2020-08-12T02:13:36Z

.github/CODEOWNERS

+/CODE_OF_CONDUCT.md @nodejs/tsc @nodejs/community-committee
+/CONTRIBUTING.md @nodejs/tsc @nodejs/community-committee
+/LICENSE @nodejs/tsc @nodejs/community-committee
+/GOVERNANCE.md @nodejs/tsc @nodejs/community-committee


So, historically the CommComm has not been an owner of Governance / Contributing of nodejs/node. I'm not saying that we can't make this change (I've already approved this PR) but I do think this is a fairly large change from what we've done until now... and AFAICT from the charter of the commcomm it is slightly out of scope imho.

I could see how Code of Conduct, License, and potentially Contributing could fall under CommComm but I'm a little less easy about including governance, specifically because this is something the TSC is chartered to manage. CommComm members do not automatically get commit rights for this repo, so it seems a bit out of scope. For the record I would say the same thing about auto adding the TSC to the governance document of any working group.

I have no objection to @MylesBorins’s comments here.

That makes sense, I'll update :)

Updated, kept CommComm on License, Contributing and both Code of Conduct files (yes, we have two)

@MylesBorins ... while that is true, keep in mind that this doesn't change the process for modifying those. It still requires no objections from TSC to modify any part of the governance. There's likely no harm in CommComm being notified of these changes.

I guess this is semantics about if CodeOwners is being used to automate notifications or if it signals ownership / signoff. I was assuming the latter, but my impression seems to be off.

It's ... both? ;-) CODEOWNERS is: these are the people who really need to be aware of these changes. Given that we have a Must Object approach rather than a Must Agree approach, however, with the governance docs it still comes down to TSC objections being most critical. That said, if someone from commcomm raises an objection (or anyone else for that matter), there's going to be an effort made to resolve that before moving forward, regardless of CODEOWNERS

That said, if someone from commcomm raises an objection (or anyone else for that matter), there's going to be an effort made to resolve that before moving forward, regardless of CODEOWNERS

Thinking about this a bit more I think what is most important here is that the TSC is onboard with this specific commitment, and since it at least to me appears to be a deviation from current norms that we have broadly made folks aware of this commitment.

What I would not like to see happen is there be an objection in the future that is simply dismissed, or some form of contention that is created by some folks maybe not being ok with this commimtent.

To be clear I'm +1 on making this committment.

I wouldn't expect any objections to be dismissed and would be unpleasantly surprised if it happened either today or after we land this. Collaborators can object to any changes to this repository that target the default branch, in which case: 1) consensus attempt is made via discussions in the PR; 2) objection is escalated to the TSC, who can try to mediate or go to a vote if mediation fails. We don't have exceptions for specific files in the current process.

Either way, CODEOWNERS is not mentioned anywhere in our collaboration docs today, which means it has no clear definition yet, and therefore is only used/considered for notifications.

(just describing what we have today, doesn't mean we can't or should make changes in the future)

mcollina

lgtm

github-actions · 2020-08-14T01:58:11Z

Commit Queue failed

- Loading data for nodejs/node/pull/34737
✔  Done loading data for nodejs/node/pull/34737
----------------------------------- PR info ------------------------------------
Title      meta: add TSC as owner of governance-related docs (#34737)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     mmarchini:codeowners-tsc -> nodejs:master
Labels     meta
Commits    1
 - meta: add TSC as owner of governance-related docs
Committers 1
 - Mary Marchini 
PR-URL: https://github.com/nodejs/node/pull/34737
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Myles Borins 
Reviewed-By: Matteo Collina 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Beth Griggs 
Reviewed-By: Shelley Vohr 
Reviewed-By: Trivikram Kamat 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/34737
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Myles Borins 
Reviewed-By: Matteo Collina 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Beth Griggs 
Reviewed-By: Shelley Vohr 
Reviewed-By: Trivikram Kamat 
--------------------------------------------------------------------------------
   ✖  No CI runs detected
   ℹ  This PR was created on Tue, 11 Aug 2020 21:25:20 GMT
   ✔  Approvals: 8
   ✔  - Anna Henningsen (@addaleax) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465441856
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465448967
   ✔  - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465544833
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465634628
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465827310
   ✔  - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465833525
   ✔  - Shelley Vohr (@codebytere) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465985239
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/34737#pullrequestreview-466491120
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

nodejs-github-bot · 2020-08-14T04:47:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32780/

nodejs-github-bot · 2020-08-14T22:32:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32793/

github-actions · 2020-08-14T23:21:00Z

Landed in 5f78dea

PR-URL: #34737 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 11, 2020

addaleax approved these changes Aug 11, 2020

View reviewed changes

jasnell approved these changes Aug 11, 2020

View reviewed changes

bnb approved these changes Aug 11, 2020

View reviewed changes

mmarchini force-pushed the codeowners-tsc branch from 6779a44 to 2b9c839 Compare August 12, 2020 01:31

MylesBorins approved these changes Aug 12, 2020

View reviewed changes

MylesBorins reviewed Aug 12, 2020

View reviewed changes

meta: add TSC as owner of governance-related docs

984429a

mmarchini force-pushed the codeowners-tsc branch from 2b9c839 to 984429a Compare August 12, 2020 02:58

mcollina approved these changes Aug 12, 2020

View reviewed changes

gireeshpunathil approved these changes Aug 12, 2020

View reviewed changes

BethGriggs approved these changes Aug 12, 2020

View reviewed changes

codebytere approved these changes Aug 12, 2020

View reviewed changes

trivikr approved these changes Aug 13, 2020

View reviewed changes

mmarchini added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2020

github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 14, 2020

MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2020

mmarchini added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 14, 2020

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2020

github-actions bot closed this Aug 14, 2020

danielleadams mentioned this pull request Aug 20, 2020

V14.9.0 proposal #34852

Merged

codebytere mentioned this pull request Sep 28, 2020

v12.19.0 proposal #35401

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

meta: add TSC as owner of governance-related docs #34737

meta: add TSC as owner of governance-related docs #34737

mmarchini commented Aug 11, 2020

nodejs-github-bot commented Aug 11, 2020

mmarchini commented Aug 11, 2020

jasnell commented Aug 11, 2020

mmarchini commented Aug 11, 2020

bnb commented Aug 11, 2020

MylesBorins left a comment

MylesBorins Aug 12, 2020 •

edited

Loading

bnb Aug 12, 2020

mmarchini Aug 12, 2020

mmarchini Aug 12, 2020

jasnell Aug 12, 2020

MylesBorins Aug 12, 2020

jasnell Aug 12, 2020

MylesBorins Aug 12, 2020

mmarchini Aug 12, 2020

mcollina left a comment

github-actions bot commented Aug 14, 2020

nodejs-github-bot commented Aug 14, 2020

nodejs-github-bot commented Aug 14, 2020

github-actions bot commented Aug 14, 2020

meta: add TSC as owner of governance-related docs #34737

meta: add TSC as owner of governance-related docs #34737

Conversation

mmarchini commented Aug 11, 2020

Checklist

nodejs-github-bot commented Aug 11, 2020

mmarchini commented Aug 11, 2020

jasnell commented Aug 11, 2020

mmarchini commented Aug 11, 2020

bnb commented Aug 11, 2020

MylesBorins left a comment

Choose a reason for hiding this comment

MylesBorins Aug 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 14, 2020

nodejs-github-bot commented Aug 14, 2020

nodejs-github-bot commented Aug 14, 2020

github-actions bot commented Aug 14, 2020

MylesBorins Aug 12, 2020 •

edited

Loading