Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: run CI on release branches #34649

Closed
wants to merge 1 commit into from
Closed

build: run CI on release branches #34649

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

We also want to run CI on release-related branches, e.g v14.x-staging so that Releasers can see if any commits they pushed may have caused issues before opening proposal branches.

cc @MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 6, 2020
richardlau
richardlau reviewed Aug 6, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also enable for build-tarball.yml and misc.yml?

@codebytere
Copy link
Member Author

👍🏻 to fast-track?

@mmarchini mmarchini added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 6, 2020
codebytere added a commit that referenced this pull request Aug 6, 2020
@codebytere
build: run CI on release branches
e43bb2f 
PR-URL: #34649
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@codebytere
Copy link
Member Author

Landed in e43bb2f

@codebytere codebytere closed this Aug 6, 2020
@codebytere codebytere deleted the run-push-on-staging branch August 6, 2020 17:44
addaleax pushed a commit that referenced this pull request Aug 8, 2020
@codebytere @addaleax
build: run CI on release branches
2cd299b 
PR-URL: #34649
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere added a commit that referenced this pull request Aug 11, 2020
@codebytere
build: run CI on release branches
221802d 
PR-URL: #34649
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@mmarchini mmarchini mmarchini approved these changes

@addaleax addaleax addaleax approved these changes

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codebytere @addaleax @mmarchini @richardlau @nodejs-github-bot