Skip to content

[v14.x backport] util: print External address from inspect #34583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rosaxxny wants to merge 1 commit into from
Closed

[v14.x backport] util: print External address from inspect #34583

rosaxxny wants to merge 1 commit into from

Conversation

@rosaxxny
Copy link
Contributor

@rosaxxny rosaxxny commented Jul 31, 2020

Fixes: #28250

PR-URL: #34398
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Gus Caplan me@gus.host
Reviewed-By: Juan José Arboleda soyjuanarbol@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de

@rosaxxny
util: print External address from inspect
63402a6 
Fixes: nodejs#28250

PR-URL: nodejs#34398
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. v14.x labels Jul 31, 2020
@rosaxxny rosaxxny changed the title util: print External address from inspect [v14.x backport] util: print External address from inspect Jul 31, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 31, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32579/

danielleadams pushed a commit that referenced this pull request Aug 4, 2020
@rosaxxny
util: print External address from inspect
f46649b 
Fixes: #28250

PR-URL: #34398
Backport-PR-URL: #34583
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams
Copy link
Contributor

danielleadams commented Aug 4, 2020

Landed in f46649b

addaleax pushed a commit that referenced this pull request Sep 22, 2020
@rosaxxny @addaleax
util: print External address from inspect
f958853 
Fixes: #28250

PR-URL: #34398
Backport-PR-URL: #34583
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@rosaxxny @addaleax
util: print External address from inspect
9027a87 
Fixes: #28250

PR-URL: #34398
Backport-PR-URL: #34583
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

+1 more reviewer

@danielleadams danielleadams danielleadams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rosaxxny @nodejs-github-bot @danielleadams @BethGriggs