src,doc,test: remove String::New default parameter #34248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kNormal` has been the implicit default for a while now (since V8 7.6). Refs: v8/v8@e0d7f81
nodejs-github-bot
added
c++
Collaborator
20 tasks
tniessen
approved these changes
Jul 9, 2020
addaleax
added
the
author ready
Collaborator
jasnell
approved these changes
Jul 9, 2020
Member
|
@addaleax ... To make this easier to backport, I would separate out the changes to any of the quic files into a separate commit. |
Member
Author
|
@jasnell I’m expecting to have to backport this manually everywhere anyway ;) |
addaleax
added a commit
that referenced
this pull request
Jul 14, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6). Refs: v8/v8@e0d7f81 PR-URL: #34248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in a038199 |
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jul 14, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6). Refs: v8/v8@e0d7f81 PR-URL: nodejs#34248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jul 14, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6). Refs: v8/v8@e0d7f81 PR-URL: nodejs#34248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 14, 2020
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6). Refs: v8/v8@e0d7f81 Backport-PR-URL: #34358 PR-URL: #34248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6). Refs: v8/v8@e0d7f81 Backport-PR-URL: #34358 PR-URL: #34248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6). Refs: v8/v8@e0d7f81 PR-URL: #34248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kNormalhas been the implicit default for a while now (since V8 7.6).Refs: v8/v8@e0d7f81
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes