Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: change "considered experimental" to "experimental" in n-api.md #34129

Closed
wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 30, 2020

This changes "considered" experimental" to "experimental" in the
n-api.md file and introduces some additional brevity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jun 30, 2020
@Trott
Copy link
Member Author

Trott commented Jul 1, 2020

@nodejs/documentation

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 1, 2020
Trott added a commit that referenced this pull request Jul 2, 2020
This changes "considered" experimental" to "experimental" in the
n-api.md file and introduces some additional brevity.

PR-URL: #34129
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 2, 2020

Landed in f06df17

@Trott Trott closed this Jul 2, 2020
@Trott Trott deleted the considered-napi branch July 2, 2020 12:38
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
This changes "considered" experimental" to "experimental" in the
n-api.md file and introduces some additional brevity.

PR-URL: #34129
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
This changes "considered" experimental" to "experimental" in the
n-api.md file and introduces some additional brevity.

PR-URL: #34129
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
This changes "considered" experimental" to "experimental" in the
n-api.md file and introduces some additional brevity.

PR-URL: #34129
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants